Conversation
LilyWangLL
added
the
category:new-port
|
Regarding the issue of dependency on Please refer to the comments for more details: #42678 (comment). |
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO zaphoyd/websocketpp | ||
| REF 56123c87598f8b1dd471be83ca841ceae07f95ba |
There was a problem hiding this comment.
This port was explicitly removed in #42678 due to being entirely unmaintained and unable to be built with current versions of Boost. Has anything changed about that situation?
There was a problem hiding this comment.
it does seem to be compiling, at least on my machine but it's not under active maintenance anymore(last update was 5yrs ago), so I'm considering dropping this PR
There was a problem hiding this comment.
the x86 ci fail is just from a version check failing which is weird since I've made sure to use vcpkg x-add-version websocketpp --overwrite-version
There was a problem hiding this comment.
It installs the port but can you actually use the port for anything with the version of Boost we have?
There was a problem hiding this comment.
(I didn't address the version database failure because there's no point in touching that with the 'what changed between when this was intentionally deindexed and now?' question outstanding. If somehow the port was usable the right fix is probably to bring back the exact git tree that was deindexed which had some patch fixes and similar...)
There was a problem hiding this comment.
https://github.com/zaphoyd/websocketpp/blob/1b11fd301531e6df35a6107c1e8665b1e77a2d8e/CMakeLists.txt#L218
considering this line, I'm going to say no because this explicitly wants boost 1.39.0 or up to 1.46.1 which is way behind that which is in vcpkg(1.87.0) so I'm going to be closing this PR. The issue regarding adding this port should also be closed, since the situation is unlikely to ever change.
3 participants
Fixes #44640
Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, allfind_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.